Fix bug with app based screen text filtering - #67
Open
rantahar wants to merge 1 commit into
Open
Conversation
…tch collection criteria
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When screen text is filtered by application, screen text is still collected to a buffer from all applications. This buffer is only emptied when the active application matches the filtering. When a matching application is encountered, the whole buffer is included on the next row of data.
This change moves the line that empties the buffer outside the if statement for filtering applications. The buffer is emptied after every capture. As far as I can see, this should not affect the rest of the workflow.