feat(model-reader): ship authenticated RVT snapshots and managed Windows host - #468
Conversation
…-reader-host # Conflicts: # CLAUDE.md
63bf50e to
f9133f3
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63bf50e35a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let stat; let real; | ||
| try { stat = await fs.lstat(filePath); real = await fs.realpath(filePath); } | ||
| catch (error) { providerError(`reference-${label}-unavailable`, `${label} is unavailable.`, false, error); } | ||
| if (!stat.isFile()) providerError(`reference-${label}-unsafe`, `${label} must be a regular file.`); |
There was a problem hiding this comment.
On POSIX systems where the test can create a symlink, lstat() reports that symlink as neither a regular file nor a followed target, so this branch throws “must be a regular file” before the explicit link/reparse check can run. Consequently the newly added model-provider.test.mjs assertion expecting /link|reparse/ fails, making the Ubuntu bridge CI job fail consistently; check isSymbolicLink() before isFile().
Useful? React with 👍 / 👎.
1 participant
Addresses #453
Addresses #464
Summary
Verification
npm test— 281/281 passingcargo fmt --all -- --checkcargo clippy --all-targets -- -D warningsnpm run buildnpm run test:windows-harness