Skip to content

Fix the CI claim in the check-provider note - #7

Merged
mobileoverlord merged 1 commit into
mainfrom
misc-1112/fix-stale-avocado-os-refs
Nov 19, 2026
Merged

mobileoverlord merged 1 commit into
mainfrom
misc-1112/fix-stale-avocado-os-refs

Conversation

@jetm

@jetm jetm commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Problem

agent/README.md says the compile-time guard is the real enforcement point because avocado-os has no CI or pre-commit hook. That described the repository the extension used to live in.

Solution

Say what is true here: this repository has no pre-commit hook, and CI reaches the guard only through the compile.

Reviewer notes

Second part of the avocado-os cleanup that started with avocado-linux/bsp-qemux86-64#3. Comments and docs only, no behavior change. The repo has test.yml, which builds the extension through the shared workflow. I read that file but did not run the CI to watch the guard fire.

The README says the compile-time guard is the real enforcement point
because avocado-os has no CI or pre-commit hook. That described the
repository the extension used to live in. This repository has a
test.yml that builds the extension through the shared workflow, so the
guard does run in CI, but it has no pre-commit hook.

Say what is true here: no pre-commit hook, and CI reaches the guard
only through the compile.

Signed-off-by: Javier Tia <javier@peridio.com>

@mobileoverlord mobileoverlord left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Docs-only, and accurate: test.yml builds through the shared workflow, so CI reaches the guard via the compile.

@mobileoverlord
mobileoverlord merged commit 9544932 into main Nov 19, 2026
1 check passed
@mobileoverlord
mobileoverlord deleted the misc-1112/fix-stale-avocado-os-refs branch November 19, 2026 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants