Repository navigation
Fix the CI claim in the check-provider note - #7
Merged
Merged
Conversation
The README says the compile-time guard is the real enforcement point because avocado-os has no CI or pre-commit hook. That described the repository the extension used to live in. This repository has a test.yml that builds the extension through the shared workflow, so the guard does run in CI, but it has no pre-commit hook. Say what is true here: no pre-commit hook, and CI reaches the guard only through the compile. Signed-off-by: Javier Tia <javier@peridio.com>
mobileoverlord
approved these changes
Nov 19, 2026
mobileoverlord
left a comment
Contributor
There was a problem hiding this comment.
Approved. Docs-only, and accurate: test.yml builds through the shared workflow, so CI reaches the guard via the compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
agent/README.mdsays the compile-time guard is the real enforcement point because avocado-os has no CI or pre-commit hook. That described the repository the extension used to live in.Solution
Say what is true here: this repository has no pre-commit hook, and CI reaches the guard only through the compile.
Reviewer notes
Second part of the avocado-os cleanup that started with avocado-linux/bsp-qemux86-64#3. Comments and docs only, no behavior change. The repo has
test.yml, which builds the extension through the shared workflow. I read that file but did not run the CI to watch the guard fire.