Repository navigation
Stop asserting a mechanism for the ring-only rule - #4
Merged
Merged
Conversation
The guard justified forbidding aws-lc-rs by the libc the agent cross-compiles against. No build has ever targeted that libc: every triple built is a glibc one, and no published feed carries a musl or 32-bit ARM target to build against. The obvious replacement is also false, which is why this records what was measured rather than a better-sounding reason. Building this crate for x86_64-avocado-linux-gnu without the cross toolchain on PATH fails inside ring's own build.rs with ToolNotFound for x86_64-avocado-linux-gcc, so ring carries C and assembly and needs a cross C compiler like any other. "ring is pure Rust, aws-lc-rs is not" does not distinguish them. A wrong reason is worse than none on a constraint like this. The next person to widen the target set checks whether the stated condition still holds, finds it never applied, and reasonably concludes the rule is stale - which is how a real constraint gets dropped. Recording the rule as inherited convention, naming both refuted explanations and the measurement that would settle it, leaves that reader with something they can act on instead. Only the comment changes. Both cargo tree queries and the three-way exit contract are untouched, so a tree that passed before passes now. Signed-off-by: Javier Tia <javier@peridio.com>
nicksinas
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
check-provider.shjustified forbiddingaws-lc-rsby the libc the agentcross-compiles against - "the musl SDK, which clears only the ring stack". No build
has ever targeted that libc. Every triple built is a glibc one, and no published feed
carries a musl or 32-bit ARM target to build against.
The obvious replacement is also false. Building this crate for
x86_64-avocado-linux-gnuwithout the cross toolchain on PATH fails inside ring'sown build script:
So ring carries C and assembly and needs a cross C compiler like any other crate.
"ring is pure Rust, aws-lc-rs is not" does not distinguish them.
Solution
Record the rule as inherited convention from
avocado-conn, name both refutedexplanations so neither gets rediscovered and written back in, and name the
measurement that would actually settle it: build the crate for each target with
aws-lc-rssubstituted forringand record which targets fail and how.A wrong reason is worse than none here. The next person to widen the target set
checks whether the stated condition still holds, finds it never applied, and
reasonably concludes the rule is stale - which is how a real constraint gets dropped.
Reviewer notes
cargo treequeries and the three-way exit contract areuntouched, so a tree that passed before passes now.
shellcheckclean.measurement, because this is the second wrong one.
avocado-connenforces the same rule; only its stated justification changes.