Conversation
GarbageCollectedWAL is the top most WAL that the Epoch holds, but it needs to have Close() in order to fully implement WriteAheadLog. Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
samliok
approved these changes
Jul 2, 2026
samliok
left a comment
samliok
left a comment
Collaborator
There was a problem hiding this comment.
approving but i looked in the orchestrator pr and we always set retention term to max int. if we are doing this why even have retention term at all?
Collaborator
Author
Well, if we use retention term maxint - it's to garbage collect everything. However, we cannot only garbage collect upon epoch change. We also want to do that occasionally on some cadence to free up storage space. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GarbageCollectedWAL is the top most WAL that the Epoch holds, but it needs to have Close() in order to fully implement WriteAheadLog.