fix(agent): drop archived neofetch, fix broken node/yarn install - #255
Open
AmirF194 wants to merge 1 commit into
Open
fix(agent): drop archived neofetch, fix broken node/yarn install#255AmirF194 wants to merge 1 commit into
AmirF194 wants to merge 1 commit into
Conversation
services/agent/Dockerfile installed neofetch via apt-get, but the package has been dropped from the Ubuntu/Debian archives the linuxserver/webtop base image tracks, so the build fails immediately with "E: Unable to locate package neofetch" (exit code 100). Fixing that surfaces two more breaks in the same build: the npm bootstrap script (curl -L https://npmjs.org/install.sh | sh) refuses to run without Node.js already present, since nothing in the image installs it, and the current npm no longer accepts the --unsafe-perm flag the yarn install step passes, so it exits with "Unknown cli flag: --unsafe-perm". Drop neofetch (a display tool, not used by anything else in the image) in favor of nodejs, and drop --unsafe-perm from the yarn install. Fixes av#240
Author
|
No rush, just checking in after a week. Happy to rebase or split the node/yarn fix out separately if that's easier to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
services/agent/Dockerfilefails to build.apt-get installincludesneofetch, which has been dropped from the Ubuntu archives thelinuxserver/webtopbase image tracks, so the build exits withE: Unable to locate package neofetch(exit code 100) before it gets anywhere near the agent sources.Fixing that surfaces two more breaks further down the same build:
curl -L https://npmjs.org/install.sh | shrefuses to run with "npm cannot be installed without node.js" because nothing in the image installs Node.js.npm install -g --unsafe-perm yarnfails with "Unknown cli flag: --unsafe-perm" because the npm version the install script fetches no longer accepts that flag.Fix
neofetchin favor ofnodejsin theapt-get installlist (neofetchis a display tool and nothing else in the image or the agent sources references it).--unsafe-permfrom theyarninstall.Verification
docker buildagainst unpatchedservices/agent/Dockerfile(build contextservices/agent, HEADff2314e): fails at theapt-get installstep withE: Unable to locate package neofetch.Successfully built), andnode --version/npm --version/yarn --versionall resolve inside the built image..github/workflows/*.yml: no lint or test workflow's path filters coverservices/agent/**, andharbor.sh dev linthas no Dockerfile pass, so there is no CI gate on this file; the Docker build above is the verification.Fixes #240