Skip to content

test: isolate offline suite from ambient SubLLM - #106

Closed
tom-sapletta-com wants to merge 1 commit into
mainfrom
ticket/090-hermetic-subllm-tests-v2
Closed

test: isolate offline suite from ambient SubLLM#106
tom-sapletta-com wants to merge 1 commit into
mainfrom
ticket/090-hermetic-subllm-tests-v2

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

Summary

  • make the default offline test command independent of ambient SubLLM credentials
  • preserve explicit SubLLM direct Z.AI GLM 5.3 bridge coverage
  • keep production routing unchanged

Validation

  • npm run build
  • npm test
  • ./project/governance-check.sh
  • git diff --check

Ticket: ticket-090

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deterministic Validator approval for exact head f0d3006fc730fdd081f6bc7f51a2d993316f34da.

Ticket: ticket-090
Correlation ID: todo2code-pr-106-ticket-090
Model: zai/glm-5.3
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). Ticket-090 pins the offline npm test command to T2C_USE_SUBLLM=false, making unit tests hermetic regardless of ambient credentials, while leaving production routing and SubLLM bridge tests unchanged. Governance/evidence files for the ticket are consistent with the one-line code change. No security or test failures observed.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Merge will be attempted after this approval when explicitly authorized.

Decision record (recomputable)

DECISION D-090-9892
TICKET ticket-090
HEAD_SHA f0d3006fc730fdd081f6bc7f51a2d993316f34da
CORRELATION_ID todo2code-pr-106-ticket-090
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance=SKIPPING","Live OpenRouter contract (opt-in)=SKIPPING","Java adapter (JDK 17 required)=PASS","verify=PASS","verify=PASS","Java adapter (JDK 17 required)=PASS","koru / code-review=PASS"]
INPUT required_checks = ["verify","Java adapter (JDK 17 required)","koru / code-review"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@tom-sapletta-com

Copy link
Copy Markdown
Contributor Author

Superseded by #107: identical tree with the plan-first commit boundary required by GOV-INTENT-003.

@tom-sapletta-com
tom-sapletta-com deleted the ticket/090-hermetic-subllm-tests-v2 branch August 26, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant