Repository navigation
Point codebot's GitHub slot at the repository type gh checks against - #70
Draft
josephschorr wants to merge 1 commit into
Draft
josephschorr wants to merge 1 commit into
josephschorr wants to merge 1 commit into
Conversation
The codebot example declared its GitHub slot on a type no gh call reads, so approving a plan never covered the agent's gh writes and each one still asked for its own approval.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The codebot example is set up so that one plan approval covers the repository the agent pushes to and opens a pull request against. In practice the GitHub half never took effect: the example declared its GitHub slot on a repository type that no
ghcommand checks against. The agent's class stayed valid, the plan was approved, and everyghwrite still asked for its own approval.Summary of changes
ghcommands are authorized against, so approving the plan covers the agent'sghcalls on that repository.Alternatives considered
None.
Provenance
Ship gate
mage test:unitmage test:integrationmage test:e2eUnit passes. The first integration run had one failure and the first e2e run had three, all in unrelated scenarios and all on a heavily loaded machine. Each of the four passed when re-run on its own. A full re-run of both suites is in progress, and this stays a draft until it is green.
Regeneration
n/a
Coverage