Skip to content

Show a resolved Slack approval once instead of twice in the same thread - #68

Draft
josephschorr wants to merge 1 commit into
mainfrom
slack-resolved-approval-once
Draft

josephschorr wants to merge 1 commit into
mainfrom
slack-resolved-approval-once

Conversation

@josephschorr

Copy link
Copy Markdown
Member

Motivation

Approving a tool call in Slack left two identical "Approved" cards stacked in the thread. One was the approver's own prompt, visible only to them, rewritten into the outcome. The other was the public note beneath it, rewritten into the same outcome. An approver working through several approvals saw every one of them twice.

Summary of changes

  • When the public note in the thread takes the resolved card, the approver's own prompt is now removed instead of being rewritten into a copy of it.
  • When there is no public note, or the note could not be updated, the prompt is still edited in place as before, so the approver always keeps one record of the outcome.

Alternatives considered

  • Shrinking the public note to a one-line outcome and keeping the full card on the approver's prompt. Rejected because the prompt is visible to one person, so everyone else in the thread would lose the detail of what was approved.

Provenance

  • Author: Joseph Schorr
  • Person who read the diff:

Ship gate

  • mage test:unit
  • mage test:integration
  • mage test:e2e

Unit passes. The first integration run had one failure and the first e2e run had three, all in unrelated scenarios and all on a heavily loaded machine. Each of the four passed when re-run on its own. A full re-run of both suites is in progress, and this stays a draft until it is green.

Regeneration

n/a

Coverage

  • This does not add user-visible behavior beyond the Slack rendering change above, which the Slack sender's tests cover
  • This touches none of authorization, the SpiceDB schema, or the approver model

Approving a tool call left two identical resolved cards stacked in the
thread: the approver's own prompt, rewritten into the outcome, and the
public note beneath it, rewritten into the same outcome. When the public
note takes the resolved card, the approver's prompt is now removed rather
than rewritten. With no public note, the prompt is still edited in place.
@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
openagentprimitives Ignored Ignored Nov 12, 2026 10:31pm UTC

Request Review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant