Repository navigation
Show a resolved Slack approval once instead of twice in the same thread - #68
Draft
josephschorr wants to merge 1 commit into
Draft
josephschorr wants to merge 1 commit into
josephschorr wants to merge 1 commit into
Conversation
Approving a tool call left two identical resolved cards stacked in the thread: the approver's own prompt, rewritten into the outcome, and the public note beneath it, rewritten into the same outcome. When the public note takes the resolved card, the approver's prompt is now removed rather than rewritten. With no public note, the prompt is still edited in place.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Approving a tool call in Slack left two identical "Approved" cards stacked in the thread. One was the approver's own prompt, visible only to them, rewritten into the outcome. The other was the public note beneath it, rewritten into the same outcome. An approver working through several approvals saw every one of them twice.
Summary of changes
Alternatives considered
Provenance
Ship gate
mage test:unitmage test:integrationmage test:e2eUnit passes. The first integration run had one failure and the first e2e run had three, all in unrelated scenarios and all on a heavily loaded machine. Each of the four passed when re-run on its own. A full re-run of both suites is in progress, and this stays a draft until it is green.
Regeneration
n/a
Coverage