Repository navigation
Let a re-review asked for in a pull request's review thread update its check run - #65
Open
josephschorr wants to merge 1 commit into
Open
josephschorr wants to merge 1 commit into
josephschorr wants to merge 1 commit into
Conversation
…s check run A reply in the thread a webhook-triggered review was delivered to reaches the session that owns the pull request's check run, but reviewbot's prompt treated any person's request as a thread-only review and ended the turn when the commit already carried a conclusion. A re-review asked for there now runs in full and its conclusion replaces the one on the head commit. A review asked for elsewhere still cannot touch the check run, and now says so.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Asking reviewbot to retry a review in Slack never changed the pull request's check run, so a red (or could-not-finish) check could only be cleared by pushing a new commit.
A re-review asked for in the thread where a pull request's reviews are delivered now updates the check run:
A review asked for anywhere else (a fresh thread, a direct message) still has no access to the check run. It now says so, and points to what does update it.
Notes