Skip to content

Let a re-review asked for in a pull request's review thread update its check run - #65

Open
josephschorr wants to merge 1 commit into
mainfrom
reviewbot-thread-rereview-updates-check
Open

josephschorr wants to merge 1 commit into
mainfrom
reviewbot-thread-rereview-updates-check

Conversation

@josephschorr

Copy link
Copy Markdown
Member

What

Asking reviewbot to retry a review in Slack never changed the pull request's check run, so a red (or could-not-finish) check could only be cleared by pushing a new commit.

A re-review asked for in the thread where a pull request's reviews are delivered now updates the check run:

  • The review runs again in full against the current head commit.
  • Its outcome replaces the conclusion already on the check run, in either direction.
  • The fork gate still applies; the automation, draft and pause gates do not, since a person asked.

A review asked for anywhere else (a fresh thread, a direct message) still has no access to the check run. It now says so, and points to what does update it.

Notes

  • No permission or credential changes: the thread's session already holds the check-run tools.
  • Anyone who can talk in a pull request's review thread can now change its check result by asking for a re-review.
  • No scripted scenario covers this yet, because a scenario cannot currently combine a webhook trigger with a person's follow-up turn.

…s check run

A reply in the thread a webhook-triggered review was delivered to reaches the session that owns the pull request's check run, but reviewbot's prompt treated any person's request as a thread-only review and ended the turn when the commit already carried a conclusion. A re-review asked for there now runs in full and its conclusion replaces the one on the head commit. A review asked for elsewhere still cannot touch the check run, and now says so.
@vercel

vercel Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
openagentprimitives Ignored Ignored Preview Nov 12, 2026 2:53am UTC

Request Review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant