Repository navigation
Keep cluster-specific install changes in overlays - #62
Open
josephschorr wants to merge 2 commits into
Open
josephschorr wants to merge 2 commits into
josephschorr wants to merge 2 commits into
Conversation
oap init, oap install and oap render take --overlay <dir> (repeatable): a kustomize Component layered over the manifests oap installs, so a change such as a raised memory limit survives every re-install and upgrade instead of being reset to the bundled value. Overlays are validated against every first-party manifest before anything is built or applied. Two overlays setting one field to different values, a patch that matches nothing, and an overlay that adds or removes a resource are all refused with an error naming what to fix. Install's own per-document rewrites (images, pull secrets, mirrors) still apply after the overlays.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Overlays were reduced to patches derived from the bundled manifests, so a change to a list with no merge key carried the bundle's whole list and undid install's rewrite of an image ref inside it (an added operator arg reset the runner image to its :dev tag). Apply now reruns the overlays with the document install is about to write swapped into the base. oap render now checks overlays against the resources it emits, so a patch for a component it leaves out (Neo4j, Graphiti, Postgres without --with-postgres) is refused up front instead of failing in the final build. Conflict detection also keys volumeMounts and unnamed ports by their merge keys.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #33.
Changes made by hand on a cluster, like raising the operator's memory limit after it was OOM-killed, are reset to the bundled value by the next
oap installor upgrade. This lets people keep those changes in kustomize overlays they own instead, and replaces #52.oap init,oap installandoap rendertake--overlay <dir>, repeatable and applied in order. An overlay is a kustomize Component, so the same directory works for direct installs and for GitOps renders.Not covered yet: an install run without its overlays still resets the values. Detecting that is a follow-up.