Repository navigation
fix: export schema reflection models in the v1 type stub - #343
Open
Kayvan-Zahiri wants to merge 1 commit into
Open
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
Signed-off-by: kzahiri1 <kzahiri@dons.usfca.edu>
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
authzedbot
added a commit
to authzed/cla
that referenced
this pull request
Oct 21, 2026
Contributor
|
Is this ready for review? |
Kayvan-Zahiri
marked this pull request as ready for review
November 5, 2026 19:12
Author
|
Yes, sorry for the slow reply. Marked it ready. The one red check is CodeQL's Go analysis failing with "could not process any code written in Go", which isn't related to this change. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1 runtime exports 19 schema-reflection/diff models that are missing from the hand-maintained
__init__.pyi. For example, importingReflectSchemaRequestandReflectionSchemaFilterfromauthzed.api.v1works at runtime but produces mypyattr-definederrors. Those missing types then becomeAny, hiding errors in consumers.Add the existing runtime schema-model imports and
__all__entries to the type stub. No runtime behavior or generated Protobuf files change.Add a consumer regression program that imports all 19 models through the public package, builds a filtered reflection request and response, checks serialization, and asserts the inferred field types. Run the same program at runtime and through strict mypy.
Refs #207. This addresses the schema-model export mismatch; it does not claim to resolve every runtime/stub mismatch or update generated gRPC method signatures. The open generated-API update (#342) does not change this hand-maintained stub.
Validation, Python 3.12 with the unchanged uv lock:
Signed off under the project's DCO.