Skip to content

fix!: match the backend's standardized single-level pagination shape #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lakhansamani merged 2 commits into from
Jul 23, 2026
Merged

fix!: match the backend's standardized single-level pagination shape #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38b27f3
fix!: match the backend's standardized single-level pagination shape
lakhansamani Jul 23, 2026
9f5cde5
chore(ci): bump test image to 2.4.0-rc.9
lakhansamani Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ jobs:
- name: Run integration tests
run: pnpm test # Make sure this command runs your integration tests
env:
AUTHORIZER_IMAGE: quay.io/authorizer/authorizer:2.4.0-rc.7
AUTHORIZER_IMAGE: quay.io/authorizer/authorizer:2.4.0-rc.9
6 changes: 2 additions & 4 deletions __test__/admin.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ describe('Integration Tests - AuthorizerAdmin (graphql + rest)', () => {
});
expect(addRes.errors).toHaveLength(0);

const listRes = await a.webhooks({ pagination: { limit: 50, page: 1 } });
const listRes = await a.webhooks({ limit: 50, page: 1 });
expect(listRes.errors).toHaveLength(0);
const created = listRes.data?.webhooks.find((w) =>
(w.event_name ?? '').startsWith(event),
Expand Down Expand Up @@ -219,9 +219,7 @@ describe('Integration Tests - AuthorizerAdmin (graphql + rest)', () => {
});
expect(addRes.errors).toHaveLength(0);

const listRes = await a.emailTemplates({
pagination: { limit: 50, page: 1 },
});
const listRes = await a.emailTemplates({ limit: 50, page: 1 });
expect(listRes.errors).toHaveLength(0);
const created = listRes.data?.email_templates.find(
(t) => t.event_name === event,
Expand Down
12 changes: 6 additions & 6 deletions src/admin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,13 +366,13 @@ export class AuthorizerAdmin {

// verificationRequests returns a paginated list of pending verification requests.
verificationRequests = (
params?: Types.PaginatedRequest,
params?: Types.PaginationRequest,
): Promise<Types.ApiResponse<Types.VerificationRequests>> =>
this.dispatch<Types.VerificationRequests>(
'VerificationRequests',
['graphql', 'rest'],
{
query: `query _verification_requests($params: PaginatedRequest) { _verification_requests(params: $params) { pagination { ${paginationFragment} } verification_requests { id identifier token email expires created_at updated_at nonce redirect_uri } } }`,
query: `query _verification_requests($params: PaginationRequest) { _verification_requests(params: $params) { pagination { ${paginationFragment} } verification_requests { id identifier token email expires created_at updated_at nonce redirect_uri } } }`,
operationName: '_verification_requests',
op: '_verification_requests',
},
Expand Down Expand Up @@ -515,13 +515,13 @@ export class AuthorizerAdmin {

// webhooks returns a paginated list of webhooks.
webhooks = (
params?: Types.PaginatedRequest,
params?: Types.PaginationRequest,
): Promise<Types.ApiResponse<Types.Webhooks>> =>
this.dispatch<Types.Webhooks>(
'Webhooks',
['graphql', 'rest'],
{
query: `query _webhooks($params: PaginatedRequest) { _webhooks(params: $params) { pagination { ${paginationFragment} } webhooks { ${webhookFragment} } } }`,
query: `query _webhooks($params: PaginationRequest) { _webhooks(params: $params) { pagination { ${paginationFragment} } webhooks { ${webhookFragment} } } }`,
operationName: '_webhooks',
op: '_webhooks',
},
Expand Down Expand Up @@ -626,13 +626,13 @@ export class AuthorizerAdmin {

// emailTemplates returns a paginated list of email templates.
emailTemplates = (
params?: Types.PaginatedRequest,
params?: Types.PaginationRequest,
): Promise<Types.ApiResponse<Types.EmailTemplates>> =>
this.dispatch<Types.EmailTemplates>(
'EmailTemplates',
['graphql', 'rest'],
{
query: `query _email_templates($params: PaginatedRequest) { _email_templates(params: $params) { pagination { ${paginationFragment} } email_templates { ${emailTemplateFragment} } } }`,
query: `query _email_templates($params: PaginationRequest) { _email_templates(params: $params) { pagination { ${paginationFragment} } email_templates { ${emailTemplateFragment} } } }`,
operationName: '_email_templates',
op: '_email_templates',
},
Expand Down
5 changes: 0 additions & 5 deletions src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,11 +643,6 @@ export interface AdminMeta {
is_multi_factor_auth_service_enabled: boolean;
}

// PaginatedRequest wraps the pagination input for list queries.
export interface PaginatedRequest {
pagination?: PaginationRequest | null;
}

// ListUsersRequest is the admin _users query input. query is an optional
// case-insensitive substring filter matched against email, given_name,
// family_name and nickname. Empty/absent means no filter (full list).
Expand Down
Loading