feat: myaccount API support#136
Merged
Merged
Conversation
Added dpop support for myaccount and passkeys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Changes
This PR carves the My Account API slice out of #116, which combined Passkey, My Account, and DPoP into one large diff. It's the second of three sequential branches (Passkey → My Account → DPoP), split for merge-conflict legibility.
Refer to #116 for the original review discussion and feedback — the code here was reviewed there; this PR only re-sequences it.
Features
MyAccountClient):get_factors,list_authentication_methods,get_authentication_method,delete_authentication_method,update_authentication_method,enroll_authentication_method, andverify_authentication_method. Letsa logged-in user manage their own enrolled authentication methods (passkey, email, phone, TOTP, push, recovery-code, password) against the My Account API,
scoped by fine-grained scopes like
read:me:factors.EnrollAuthenticationMethodRequest.type, not a dedicated method per type.API Changes
MyAccountClient:get_factors,list_authentication_methods,get_authentication_method,delete_authentication_method,update_authentication_method,enroll_authentication_method,verify_authentication_method.Factor,GetFactorsResponse,AuthenticationMethod,ListAuthenticationMethodsResponse,EnrollAuthenticationMethodRequest,EnrollmentChallengeResponse,VerifyAuthenticationMethodRequest,UpdateAuthenticationMethodRequest, plus type aliasesEnrollmentTypeand
PreferredAuthMethod.MyAccountApiError/ApiError/MissingRequiredArgumentError, consistent with the rest ofMyAccountClient.(prerequisites, obtaining a scoped token, all six operations, error handling). README gains a linking section;
Passkeys.mdgains a cross-reference note pointing here for passkey management (as opposed to passkey sign-in).