HexFloatLiterals - #500
Open
ijouw wants to merge 7 commits into
Open
Conversation
augustss
reviewed
Jul 31, 2026
| (Right q, len, rs) -> TRat loc q : lexSkipHash (addCol loc (2+len)) rs | ||
| | toLower x == 'b' = case readNumBin cs of | ||
| (Left n, len, rs) -> TInt loc n : lexSkipHash (addCol loc (2+len)) rs | ||
| (Right q, len, rs) -> TRat loc q : lexSkipHash (addCol loc (2+len)) rs |
Owner
There was a problem hiding this comment.
Since all the branches do the same thing, refactor the common code.
It's probably best to get rid of return Left/Right and just have readNum return the right thing.
The reason I'm picky about this is that the performance of the lexer is important.
Contributor
Author
There was a problem hiding this comment.
readNum now outputs [Token]
ijouw
commented
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow more numerical literals.
Allow non-decimal dot:
Allow non-decimal scientific notation (using e):
Introduce new scientific notation using p instead of e (s.t it does not conflict with hex
0xe = 14). Note that following HexFloatLiterals, the exponent is always base10.