Skip to content

Fix ReDoS in the commit detector; skip Vitest majors and Dependabot seals - #3

Merged
augbastos merged 1 commit into
mainfrom
fix/redos-dependabot-seal
Sep 15, 2026
Merged

augbastos merged 1 commit into
mainfrom
fix/redos-dependabot-seal

Conversation

@augbastos

Copy link
Copy Markdown
Owner

What this changes

Three follow-ups found once the first pull request reached main:

  • ReDoS in the capture hook (CodeQL py/redos, pre-existing). The regular expression that recognises git commit let the flag group split -a -b two ways, so a command like git -! -! … x backtracked exponentially and could stall the hook until its timeout. A flag's value may no longer start with -, which makes the match linear and changes no result. The regression test runs in a child process with a timeout, and it times out against the old expression.
  • Dependabot proposed Vitest 5, which cannot install: @cloudflare/vitest-plugin declares a peer of vitest ^4. Major Vitest updates are ignored until the plugin supports them.
  • scpe-seal commented "missing disclosure" on Dependabot's pull requests, which verify already exempts. It now skips them too.

AI use

Tick exactly one. This is the signal the scpe check reads — an unticked box counts as
no disclosure at all. Using AI is fine here; not saying so is what this asks about.

  • I used generative AI
  • I did not use generative AI

🤖 Generated with Claude Code

https://claude.ai/code/session_012ZGHwbkYyNewZwMVToYQbL

…abot seals

The flag group in _GIT_COMMIT could split '-a -b' two ways and backtracked exponentially on repeated flags (CodeQL py/redos). A flag value may no longer start with '-'; results are unchanged, and the regression test times out against the old expression. Dependabot ignores major Vitest updates while @cloudflare/vitest-plugin requires vitest ^4, and scpe-seal skips Dependabot's pull requests, which verify already exempts.
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 17c9b88c-e48d-4594-8e16-39a64d97d5fb


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

✅ AI-use disclosure found (checkbox: ai)

@augbastos
augbastos merged commit e9239ad into main Sep 15, 2026
16 checks passed
@augbastos
augbastos deleted the fix/redos-dependabot-seal branch September 15, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant