Fix ReDoS in the commit detector; skip Vitest majors and Dependabot seals - #3
Merged
Merged
Conversation
…abot seals The flag group in _GIT_COMMIT could split '-a -b' two ways and backtracked exponentially on repeated flags (CodeQL py/redos). A flag value may no longer start with '-'; results are unchanged, and the regression test times out against the old expression. Dependabot ignores major Vitest updates while @cloudflare/vitest-plugin requires vitest ^4, and scpe-seal skips Dependabot's pull requests, which verify already exempts.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
✅ AI-use disclosure found (checkbox: ai) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Three follow-ups found once the first pull request reached
main:py/redos, pre-existing). The regular expression that recognisesgit commitlet the flag group split-a -btwo ways, so a command likegit -! -! … xbacktracked exponentially and could stall the hook until its timeout. A flag's value may no longer start with-, which makes the match linear and changes no result. The regression test runs in a child process with a timeout, and it times out against the old expression.@cloudflare/vitest-plugindeclares a peer ofvitest ^4. Major Vitest updates are ignored until the plugin supports them.scpe-sealcommented "missing disclosure" on Dependabot's pull requests, whichverifyalready exempts. It now skips them too.AI use
Tick exactly one. This is the signal the
scpecheck reads — an unticked box counts asno disclosure at all. Using AI is fine here; not saying so is what this asks about.
🤖 Generated with Claude Code
https://claude.ai/code/session_012ZGHwbkYyNewZwMVToYQbL