Repository navigation
Reject malformed OSC blob lengths - #204
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A negative OSC blob length can move the decoder back into the previous argument. A blob with missing padding can also pass parsing even though its next offset is past the packet.
Check the signed length and make sure the whole padded blob fits before returning it. The regression tests cover both cases, including a full message where a negative length makes the final integer repeat an earlier one.
All 197 tests pass locally, along with lint, typing and the package build.
AI assistance: OpenAI Codex wrote and tested this patch.