Skip to content

Reject malformed OSC blob lengths - #204

Merged
attwad merged 1 commit into
attwad:mainfrom
civilwarinfrance:fix/osc-blob-bounds
Nov 14, 2026
Merged

attwad merged 1 commit into
attwad:mainfrom
civilwarinfrance:fix/osc-blob-bounds

Conversation

@civilwarinfrance

Copy link
Copy Markdown
Contributor

A negative OSC blob length can move the decoder back into the previous argument. A blob with missing padding can also pass parsing even though its next offset is past the packet.

Check the signed length and make sure the whole padded blob fits before returning it. The regression tests cover both cases, including a full message where a negative length makes the final integer repeat an earlier one.

All 197 tests pass locally, along with lint, typing and the package build.

AI assistance: OpenAI Codex wrote and tested this patch.

@attwad
attwad merged commit bb33cc1 into attwad:main Nov 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants