feat: support asynchronous multi-task callbacks (SDK-658)#171
Merged
brax10ward merged 1 commit intoJul 21, 2026
Merged
Conversation
- add src/transactRegistry.ts: route each Atomic.transact() launch's
callbacks by a wrapper-generated instanceId (+ unit tests)
- install one persistent listener per event; drop the removeAllListeners
teardown that let a new launch override prior tasks' callbacks
- return a TransactTask handle { instanceId, remove() }; add onCleanup and
iOS-only onError options
- tear down a task only on cleanup-application (onCleanup), not onFinish/onClose
- ios/android bridges: envelope every event as { instanceId, data }; key
data-request handlers by instanceId
- android: reclaim the registry entry on launch failure (safety net)
- ios: resolve hideTransact promise; wire onError; drop dead onCompletion
supportedEvents entry
brax10ward
marked this pull request as ready for review
July 21, 2026 16:14
eriksargent
approved these changes
Jul 21, 2026
brax10ward
deleted the
braxton/sdk-658-react-native-sdk-should-allow-for-asynchronous-task
branch
July 21, 2026 17:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear Link
https://linear.app/atomicbuilt/issue/SDK-658/react-native-sdk-should-allow-for-asynchronous-task-callbacks
Type of change
Checklist: