Repository navigation
fix: cleanup-owning run with unknown capture no longer strands its task (#16037) - #16043
Merged
Merged
Conversation
…t capture never completed (#16037) A completed run that owns its task's cleanup but never captured its checkout was settled as soon as its checkout disappeared, stranding the task in progress. The absence writer now refuses it until the task moves on, and the verifier proves delivery from the forge instead of holding on the capture.
atomantic
added
implementer:sonnet-5-5
reviewer:gpt-6-1-terra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A completed run that owns its task's cleanup (
cleanupPending) but whose terminal checkout capture failed was settled by the own-seed absence path as soon as its checkout disappeared, leaving the taskin_progressand cleanup-held with no owner able to settle it.recordAbsentCheckoutRetirementnow refuses to settle acleanupPendingrun until its task completed or names another cleanup owner (the same task-moved-on check handed-off captured checkouts already use).verifyAgentRepoStateno longer returnscheckout-capture-pendingfor a cleanup-owning run whose seed checkout, branch and worktree entry are verifiably absent; it falls through to the existing absent-checkout path, which proves a merged PR without a captured head or stays a visibleabsent-checkout-integration-unverifiedhold.Tests
Writer test (owner / unowned task refused, completed task settles), verifier test (absent seed verifies via forge delivery; present seed stays
checkout-capture-pending). Both fail without the fix.npm run pregatepasses.Local review
codex (gpt-6.1-terra, medium): 1 of 2 rounds, clean at the published head, no findings.
Closes #16037