Repository navigation
test: wait for the whole sequential save in ImageGenTab tests (#16035) - #16041
Merged
Merged
Conversation
A save PATCHes one slice at a time; awaitSave resolved on the first PATCH, so tests reading a later slice (videoGen.grok) could see it undefined under load.
atomantic
added
implementer:sonnet-5-5
reviewer:gpt-6-1-terra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImageGenTabsaves PATCH one settings slice at a time, then toast the outcome. The test helperawaitSaveresolved on the first PATCH, so tests reading a later slice (e.g.videoGen.grokin "loads and saves grok image and video parallel limits") could readundefinedunder CI load — the reportedCannot read properties of undefined (reading 'parallelLimit').awaitSavenow waits for the save's outcome toast; the one test that deliberately holds a PATCH pending uses a newawaitPatchStarted. Component unchanged; no assertion weakened.Reproduction: root cause identified by reading the sequential save loop (
handleSave) against the helper; not reproducible locally at will (file passed repeatedly). The race window is deterministic in logic: any scheduling delay between the first and second PATCH exposes it. File passes 3 consecutive local runs plus pregate.Local review
codex (gpt-6.1-terra): 1 of 2 rounds, clean, reviewed head 148cd3a.
Closes #16035