Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Add support for TreeView decorators#658

Open
philschatz wants to merge 1 commit into
atom:masterfrom
philschatz:update-icon-status
Open

Add support for TreeView decorators#658
philschatz wants to merge 1 commit into
atom:masterfrom
philschatz:update-icon-status

Conversation

@philschatz

Copy link
Copy Markdown

Allows a package to add/remove a class on the Directory or File similar to the FileIcon and the VCS updateStatus methods in tree-view.

FileIcon and the VCS updateStatus annotate the files/directories in different ways:

  • FileIcon sets the class once based on the filename but does not allow other packages to change the class on their own.
  • VCS methods in TreeView could be abstracted as a provider for decorating files and directories; most of the code so far in this Pull Request is copy/pasta from File::updateStatus.

Any thoughts on consolidating FileIcon and updateStatus methods by adding a decorator similar (but much simpler) to TextEditor::markBufferRange and TextEditor::decorateMarker?

This is a spike, mostly to see if there is interest before continuing

See the pull-requests package for the motivation for adding decorators:

pull-requests

@philschatz philschatz changed the title [WIP] Add support for TreeView decorators Add support for TreeView decorators Mar 2, 2016
@philschatz philschatz force-pushed the update-icon-status branch from 325e849 to 4302d46 Compare March 2, 2016 15:01
@philschatz

Copy link
Copy Markdown
Author

Any updates on this? I noticed other Pull Requests were given tags but maybe this one was skipped?

Also, there was a merge conflict in the tests but I rebased to remove the conflict. Thanks for making such a hackable editor!

@lee-dohm

lee-dohm commented Mar 9, 2016

Copy link
Copy Markdown
Contributor

I've put it in the queue for review. I'm not sure when the team will be able to get to it, but it looks interesting!

@dac09

dac09 commented Apr 2, 2016

Copy link
Copy Markdown

I've not dived into writing atom plugins yet - so can't comment on the code, but going to request the atom team to have a look 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants