[IT9PE1-29241] Allow Symfony 8 - #34
Merged
Merged
Conversation
Required by PHPUnit 13, which the CI resolves on highest-deps runs. The Group attributes also restore the phpunit-bridge DnsMock wiring that the dns-sensitive docblock group no longer triggered. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The 7.2.0 release (previous lowest) caps PHPUnit at 10.5 and its deprecation gate exits non-zero under PHP 8.4 even in weak mode, failing the lowest-deps CI job after all tests pass. 7.4.0 is clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
symfony/cacheand the require-devsymfony/*packages to^7.0|^8.0(symfony/phpunit-bridgeto^7.2|^8.0).@group dns-sensitivedocblock no longer triggered the phpunit-bridgeDnsMock, makingMxServersResolverTest::testDnshit real DNS and fail.#[DataProvider]/#[Group]attributes restore both.Why
Part of the Symfony 8 wave across assoconnect bundles, needed by the backend upgrade to Symfony 8.1. The CI highest/lowest dependency matrix covers both majors automatically.
Test plan
Local gate in the open-source container (PHP 8.4), with the highest resolution actually installing Symfony 8.1.5:
composer validate --strict✅vendor/bin/phpcs✅vendor/bin/phpstan✅ no errorsvendor/bin/phpunit✅ 41 tests, 44 assertions (vs 13 collected before the attribute migration)Refs IT9PE1-29241
Shipping
Merging this PR ships nothing: it needs a semver tag / GitHub release, then a
composer require assoconnect/php-smtp-toolbox:^x.ybump PR in the backend. Two reviews total.