[IT9PE1-29241] Allow Symfony 8 and DoctrineBundle 3 - #43
Merged
Conversation
DoctrineBundle 2.x caps Symfony at 7, so the highest-deps CI run needs DoctrineBundle 3 to actually resolve Symfony 8. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
symfony/*requirements (require and require-dev) to^7.0|^8.0.doctrine/doctrine-bundleto^2.12|^3.0.Why
Part of the Symfony 8 wave across assoconnect bundles, needed by the backend upgrade to Symfony 8.1.
The DoctrineBundle widening is not optional: DoctrineBundle 2.x caps Symfony at 7, so without it the highest-deps CI job would silently resolve Symfony 7.4 and the Symfony 8 side would never actually be tested. The bundle only uses
AsDoctrineListenerand theDoctrineBundleclass, both unchanged in DoctrineBundle 3.Test plan
Local gate in the open-source container (PHP 8.4), with the highest resolution actually installing Symfony 8.1.5 and DoctrineBundle 3:
composer validate --strict✅vendor/bin/phpcs✅vendor/bin/phpstan✅ no errorsvendor/bin/phpunit✅ 31 tests, 70 assertions (4 pre-existing PHPUnit notices, unrelated)CI matrix (PHP 8.4/8.5 × lowest/highest) covers the Symfony 7 + DoctrineBundle 2 side.
Refs IT9PE1-29241
Shipping
Merging this PR ships nothing: it needs a semver tag / GitHub release, then a
composer require assoconnect/log-bundle:^x.ybump PR in the backend. Two reviews total.