refactor(bazel): move the flag/rc helpers into bazel/flags.axl - #1371
Merged
Conversation
✨ Aspect Workflows Tasks📅 Sun Aug 16 07:16:34 UTC 2026 ❌ 1 failed task
|
jbedard
force-pushed
the
sc/1-bazel-flags
branch
from
August 8, 2026 06:51
1e2cafa to
b89c359
Compare
thesayyn
approved these changes
Aug 8, 2026
jbedard
force-pushed
the
sc/1-bazel-flags
branch
2 times, most recently
from
August 13, 2026 04:08
7483e4c to
b05f36b
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe Bazel helpers now live in a public ChangesBazel namespace migration
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to This refactor reorganizes Bazel helpers without an identified behavior change, and no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
`private/lib/bazel_flags.axl` becomes `bazel/flags.axl`, reached through the
`bazel` namespace the `@aspect//bazel.axl` facade now assembles. The helpers
drop their `bazel_trait` parameter and read `ctx.traits[BazelTrait]`
themselves, so a task passes only `ctx`:
bazel_flag_args("the build") -> bzl.flags.args("the build")
announce_bazel_args("the build") -> bzl.announce.args("the build")
resolve_bazel_announce(ctx) -> bzl.announce.resolve(ctx)
setup_bazel_command(ctx, cmd, trait) -> bzl.setup_command(ctx, cmd)
sibling_rc(ctx, trait, transform) -> bzl.sibling_rc(ctx, transform)
expand_config_flags(ctx, trait, flags) -> bzl.flags.expand_config(ctx, flags)
aspect_endpoint_auth_flags(ctx, ...) -> bzl.endpoint_auth_flags(ctx, ...)
`core_args` / `targets_arg` consolidate the arg bundles the bazel-driving
tasks were each spelling out.
Pure move: no behavior change. Endpoint auth rides along unchanged here and
re-homes to the deployment feature separately.
jbedard
force-pushed
the
sc/1-bazel-flags
branch
from
August 16, 2026 07:03
b05f36b to
5fa88cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
private/lib/bazel_flags.axlbecomesbazel/flags.axl, reached through thebazelnamespace the@aspect//bazel.axlfacade now assembles. The helpers drop theirbazel_traitparameter and readctx.traits[BazelTrait]themselves, so a task passes onlyctx:core_args/targets_argconsolidate the arg bundles the bazel-driving tasks were each spelling out.Pure move: no behaviour change. Endpoint auth rides along unchanged here and re-homes to the deployment feature separately.
Changes are visible to end-users: no
Test plan