Preserve Windows shell executable arguments - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Windows discovers executable paths such as
C:\Program Files\PowerShell\7\pwsh.exe. Passing the display string to pywinpty splits that path at spaces and prevents the local terminal from starting.What changed
Testing
The regression cases fail before the fix and all 11 terminal read/spawn tests pass afterward. Real Windows with pywinpty 3.0.5 reproduces the truncated executable lookup before the fix and completes shell I/O from a path containing spaces afterward. The full headless suite passes. Desktop GUI focus/input validation remains a separate release gate.