Align Desktop 0.5.0 with Core agent onboarding - #24
Merged
Merged
Conversation
askac
marked this pull request as ready for review
September 12, 2026 19:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Desktop's Agent menu produces local connection prompts even when the current tab hosts a remote agent. Core 2.12 provides one current-tab onboarding flow for both locations. On Windows, the Core view can also stop receiving input or producing captures after native window activation.
What changed
Testing
All 95 Desktop unit tests pass. Native Windows and Windows + WSL source-run tests pass repeated activation/input, Settings focus preservation, floating windows, guarded clipboard operations, PNG capture, decoded WebM recording and hide finalization. The staged Git Core update/recovery integration passes. Native Windows x64 and macOS arm64 packaged application and first-run preparation/reuse checks pass in run 34712625797. The mounted DMG and extracted Windows installer payload match all 78 formal Core files; the extracted Windows application also passes Windows and Windows + WSL input/capture/recording tests.
Packages remain evaluations: real IME and OS clipboard behavior, installer upgrade and Finder/Gatekeeper acceptance require manual checks. Windows is unsigned; macOS uses ad-hoc signing without notarization.