test: cover date-range logic and run go test in CI#3
Merged
Conversation
Add table tests for model.FromDates/FromMonth/Preset boundaries and collect.anchorMidnight, including a regression guard for the date-skew bug fixed in #2. Run 'go test -race ./...' in CI (previously only gofmt/vet/build).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2. Addresses the two highest-leverage gaps: zero test coverage, and CI that never ran
go test.Tests added
internal/model/range_test.go—FromDates(single-day, multi-day, month/year rollover, empty-todefault, bad input),FromMonth, andPresetboundary windows. IncludesTestPresetBoundaries, a regression guard asserting each preset produces a whole-day half-open[Since, Until)window — the invariant the fix: anchor git date filters to local midnight #2 bug violated.internal/collect/git_test.go—anchorMidnight: bare ISO dates get00:00:00; relative strings ("7 days ago","yesterday"), empty, and already-timed values pass through untouched.CI
Added
go test -race ./...to.github/workflows/ci.yml(previously onlygofmt,go vet,go build).Verification
go test -race ./...→ all green locally.