Skip to content

fix: anchor git date filters to local midnight #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashishxcode merged 1 commit into from
May 25, 2026
Merged

fix: anchor git date filters to local midnight #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions internal/collect/git.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,24 @@ import (
"os/exec"
"path/filepath"
"strings"
"time"

"github.com/ashishxcode/commit-chronicle/internal/model"
)

const fieldSep = "\x1f" // ASCII unit separator

// anchorMidnight pins a bare YYYY-MM-DD to local midnight. git's --since/--until
// parse a bare date via approxidate, which fills the missing time with the
// *current* time of day — skewing every window by the wall clock. Relative
// strings (e.g. "7 days ago") are passed through untouched.
func anchorMidnight(when string) string {
if _, err := time.Parse("2006-01-02", when); err == nil {
return when + " 00:00:00"
}
return when
}

// gitCommits returns de-duplicated commits authored by `author` in the range,
// across all refs in each repo.
func gitCommits(repos []string, author string, r model.Range) []model.Item {
Expand All @@ -25,10 +37,10 @@ func gitCommits(repos []string, author string, r model.Range) []model.Item {
"--pretty=format:%h" + fieldSep + "%H" + fieldSep + "%ad" + fieldSep + "%s",
}
if r.Since != "" {
args = append(args, "--since="+r.Since)
args = append(args, "--since="+anchorMidnight(r.Since))
}
if r.Until != "" {
args = append(args, "--until="+r.Until)
args = append(args, "--until="+anchorMidnight(r.Until))
}

out, err := exec.Command("git", args...).Output()
Expand Down
Loading