Repository navigation
docs(spaces): spell out the KEM key in the upgrade notes; fix the garbage-cursor check under OAuth - #257
Merged
Conversation
…robe type An unfiltered listSpaces needs a wildcard space grant, so an OAuth session scoped to the probe type was refused with InsufficientScope before the cursor was read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LZ7qcQNQoiA6a23woGC7tB
The 1112 changeset gains an upgrade checklist: reset, create the #atproto_kem key, publish it on did:plc (running pds rotation-keys first if the PDS can't sign PLC operations), and check with pds spaces status. Without the key, credentialed reads fail with 503 KemKeyUnavailable. The guide and pds spaces kem point at pds rotation-keys too, and the command narrows the PLC audit log entry to a plc_operation, as rotation-keys does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LZ7qcQNQoiA6a23woGC7tB
commit: |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
pdscheck | 72cbdd7 | Nov 19 2026, 10:58 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
cirrusdocs | 72cbdd7 | Commit Preview URL Branch Preview URL |
Nov 19 2026, 10:58 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up #256, based on a run of the browser conformance checker against pds.mk.gg: 61 pass, 12 fail. None of the failures is a bug in Cirrus's protocol code.
KEM key in the upgrade notes
Eleven of the twelve failures share one cause: the deployment has no
#atproto_kemkey. Without it, every credentialed read that needs a MAC answers503 KemKeyUnavailable. The step was only mentioned in passing in the 1105 changeset, so it was easy to miss.Changeset:
spaces-alpha-20261112.mdnow starts with an upgrade checklist:pds spaces reset.pds spaces kem, and redeploy.pds spaces kem --publish, runningpds rotation-keysfirst if the PDS can't sign PLC operations.pds spaces status.did#service.The checklist also says what fails without the key.
Guide and CLI: the enable-spaces guide and the
pds spaces kemhints now point atpds rotation-keys. Since feat(pds): give Cirrus a PLC rotation key and offer recovery keys #253,signPlcOperationrefuses when the PDS's key isn't a rotation key, and names that command as the fix.Type fix:
pds spaces kem --publishnow narrows the PLC audit log entry to aplc_operation, asrotation-keysdoes. Since feat(pds): give Cirrus a PLC rotation key and offer recovery keys #253 the entry type is a union, which tsc flagged. At runtime, a tombstoned or legacy DID now gets a clear message instead of a malformed operation.Garbage-cursor check under OAuth
The twelfth failure was
request.garbage-cursor-rejected, which answeredlistSpaces → 403 InsufficientScope. The check calledlistSpaceswith no type filter, and an unfiltered listing needs a wildcard space grant. So the checker's OAuth session, scoped to the probe type, was refused before the cursor was read. That's correct behaviour from Cirrus. The check now filters to the probe type and the target DID, asspace.listspaces-filtersalready does. The conformance changeset notes this.Verification
Generated by Claude Code