feat: allow users to supply custom token_endpoint for token creation - #90
Open
ssiva wants to merge 3 commits into
Open
feat: allow users to supply custom token_endpoint for token creation#90ssiva wants to merge 3 commits into
ssiva wants to merge 3 commits into
Conversation
In certain Aruba Central deployments, likes of OnPrem and internal QA clusters, token creation fails as it reaches the wrong token endpoint. Allow users to supply a custom `token_url` to override the default OAuth token endpoint used for token creation and refresh. Signed-off-by: Siva Shanmugam <164997+ssiva@users.noreply.github.com>
KarthikSKumar98
requested changes
Aug 3, 2026
KarthikSKumar98
left a comment
KarthikSKumar98
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for adding the override. Before we merge, please update:
pycentral/utils/base_utils.py: renametoken_urltotoken_endpoint.docs/getting-started/authentication.md: document the new field, include an example, and state that it is used for automatic renewal too. Also include that this relevant only for Central On-Prem (non-MSP accounts) instances only.
Renamed the user-facing `token_url` key to `token_endpoint`. Updated the documentation for the `token_endpoint` field with examples in the authentication.md Signed-off-by: Siva Shanmugam <164997+ssiva@users.noreply.github.com>
Author
|
@KarthikSKumar98 - Thanks, renamed the field to token_endpoint and updated the documentation as requested. |
ssiva
changed the title
ssiva
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain Aruba Central deployments, likes of OnPrem and internal QA clusters, token creation fails as it reaches the wrong token endpoint.
Allow users to supply a custom
token_endpointto override the default OAuth token endpoint used for token creation and refresh.