docs(tutorials): add end-to-end playbook examples#69
Merged
Conversation
There was a problem hiding this comment.
Thanks for expanding the worked examples — Examples 10 and 11 look good. One blocking issue in Example 9: the Alloy play uses hosts: k3s_all, but that example's inventory.ini never defines a k3s_all group (only k3s_server and k3s_agents), so a reader copying it runs the monitoring play against zero hosts. Add a [k3s_all:children] group as Example 2 does (suggestion left inline). Also flagged non-blocking: the k3s_agents worker is declared but never joined to the cluster.
Add three worked examples to the tutorials guide (k3s with Fleet and monitoring, multi-host firewall, secret management) so readers have complete, copy-ready playbooks beyond the basic snippets. Signed-off-by: Simon Bärlocher <s.baerlocher@sbaerlocher.ch>
Add the missing k3s_all group so the Alloy play targets real hosts instead of zero, and add an agent-join play so the worker actually joins the cluster — addresses review findings. Signed-off-by: Simon Bärlocher <s.baerlocher@sbaerlocher.ch>
910cd3b to
320c7d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan