Add squirrel tests - #17
Merged
Merged
Conversation
…names be modifiable
Revert arfc@7ff814d#diff-0aea5faa4a76003610576e14bb18841cebc25f74b46275bd6674c328da93733c which inadvertently commented out parts of the MatINSTemperatureTimeDerivative Jacobian definition
katyhuff
approved these changes
Sep 21, 2026
| # Adapted from the RACCOON project's test workflow: | ||
| # https://github.com/hugary1995/raccoon/blob/devel/.github/workflows/tests.yml | ||
|
|
||
| name: Tests |
Member
There was a problem hiding this comment.
Should we be more explicit (SquirrelTests) ?
Collaborator
Author
There was a problem hiding this comment.
Sounds good. I'll change it to Squirrel CI Testing
Comment on lines
+13
to
+14
| params.addParam<MaterialPropertyName>("rho", "rho", "Density material property name"); | ||
| params.addParam<MaterialPropertyName>("cp", "cp", "Specific heat material property name"); |
Member
There was a problem hiding this comment.
Suggested change
| params.addParam<MaterialPropertyName>("rho", "rho", "Density material property name"); | |
| params.addParam<MaterialPropertyName>("cp", "cp", "Specific heat material property name"); | |
| params.addParam<MaterialPropertyName>("rho", "rho", "Density material property"); | |
| params.addParam<MaterialPropertyName>("cp", "cp", "Specific heat material property"); |
Should these include units?
Collaborator
Author
There was a problem hiding this comment.
No because Moltres and Squirrel are unit-agnostic. Users have the freedom of choosing their own units (and the responsibility of ensuring consistency across their mesh, group constants, material properties).
Comment on lines
+10
to
+11
| params.addParam<MaterialPropertyName>("rho", "rho", "Density material property name"); | ||
| params.addParam<MaterialPropertyName>("cp", "cp", "Specific heat material property name"); |
Member
There was a problem hiding this comment.
Suggested change
| params.addParam<MaterialPropertyName>("rho", "rho", "Density material property name"); | |
| params.addParam<MaterialPropertyName>("cp", "cp", "Specific heat material property name"); | |
| params.addParam<MaterialPropertyName>("rho", "rho", "Density material property"); | |
| params.addParam<MaterialPropertyName>("cp", "cp", "Specific heat material property"); |
Comment on lines
+13
to
+14
| params.addParam<MaterialPropertyName>("rho", "rho", "Density material property name"); | ||
| params.addParam<MaterialPropertyName>("cp", "cp", "Specific heat material property name"); |
Member
There was a problem hiding this comment.
Suggested change
| params.addParam<MaterialPropertyName>("rho", "rho", "Density material property name"); | |
| params.addParam<MaterialPropertyName>("cp", "cp", "Specific heat material property name"); | |
| params.addParam<MaterialPropertyName>("rho", "rho", "Density material property"); | |
| params.addParam<MaterialPropertyName>("cp", "cp", "Specific heat material property"); |
Renamed CI workflow from 'Tests' to 'Squirrel Continuous Integration (CI) Testing' per PR review comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge #18 before this PR. Fixes #16
Summary
Adds CI test coverage for all objects in squirrel. Squirrel was previously indirectly covered by Moltres CIVET testing. But many objects were not tested for their functionality, thus we only caught build issues.
Contains fixes for several bugs or missing functionality that I deemed essential.
Fixes missing test function calls in DiffusiveFluxBC and InterTemperatureAdvection.
Fixes missing material property input params for rho and cp in PostprocessorTemperatureInflowBC, VelocityFunctionTemperatureOutflowBC, DGFunctionTemperatureAdvection, and VelocityFunctionTemperatureAdvection.
Adds PostprocessorVelocityFunctionTemperatureInflowBC for an inflow BC that accepts a velocity function. The inlet temperature postprocessor also accepts constant scalar values.
List of Changes