[MINOR BC] [4.x] Make DeleteTenantStorage not depend on the suffix_storage_path config - #1479
[MINOR BC] [4.x] Make DeleteTenantStorage not depend on the suffix_storage_path config#1479lukinovec wants to merge 4 commits into
Conversation
lukinovec
commented
Aug 8, 2026
lukinovec
commented
The job should delete the tenant storage regardless of the suffix_storage_path config. Now, the job depends on that config, so currently, this test fails. Also remove the "FS bootstrapper disabled" assertions. The job clearly depends on the bootstrapper being enabled, so I don't think these assertions matter in the end.
…ss of suffix_storage_path The job depended on storage_path(), which is only suffixed when suffix_storage_path is enabled, so with it disabled the tenant's files were left behind. It now uses the bootstrapper's own suffix logic via a new getBoundTenantStoragePath() method..
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## scope-cache-fix #1479 +/- ##
=====================================================
- Coverage 86.75% 86.74% -0.02%
+ Complexity 1228 1227 -1
=====================================================
Files 186 186
Lines 3601 3598 -3
=====================================================
- Hits 3124 3121 -3
Misses 477 477 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The symlinks should point to the tenant's disk root regardless of the suffix_storage_path config and of which root_override placeholders are used. Currently, the storage_path() helper is used for generating the symlink path, so the two new datasets fail.
…age_path() possibleTenantSymlinks() resolved the root_override template on its own, using storage_path() for %storage_path% and leaving %original_storage_path% and %tenant% unreplaced. Let the FS bootstrapper resolve the placeholders tenant instead, so the symlinks point where the disks actually write.
1 participant
