security: harden github actions#53
Open
m1rm wants to merge 11 commits into
Open
Conversation
m1rm
force-pushed
the
security/harden-github-actions
branch
from
May 20, 2026 10:01
a12aef9 to
40b2afb
Compare
pierres
requested changes
Jun 13, 2026
| with: | ||
| token: ${{ secrets.MAINTENANCE_TOKEN }} | ||
| fetch-depth: 0 | ||
| persist-credentials: false |
Member
There was a problem hiding this comment.
As seen in the other repos, the update workflow seems to need the credentials in order to push the commits.
Author
There was a problem hiding this comment.
committed a tryout with passing the maintenance token explicitly needs work. on it
Author
There was a problem hiding this comment.
passing the token via env should fix this:
uses: stefanzweifel/git-auto-commit-action@04702edda442b2e678b25b537cec683a1493fcb9 #v7.1.0
env:
GITHUB_TOKEN: ${{ secrets.MAINTENANCE_TOKEN }}git describe --tags fails on my fork because the fork does not have any tags
m1rm
marked this pull request as draft
June 14, 2026 16:40
security: harden github actions
hardened checkout step strips away the persistent Git environment. When just tries git describe --tags it either gets an access denied or empty string, malforming Go's -ldflags which breaks the docker build sequence
m1rm
force-pushed
the
security/harden-github-actions
branch
from
June 21, 2026 11:16
5ac4152 to
9d4b1db
Compare
…a .dockerignore and build-arg instead of copying .git or relying on checkout credentials
m1rm
marked this pull request as ready for review
June 21, 2026 12:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.