Deploy production through declarative config#19
Merged
Conversation
Greptile SummaryThis PR replaces the direct Helm-based production deployment with the same declarative
Confidence Score: 5/5Safe to merge — the workflow correctly isolates the build step to release events only, and the deploy step handles both trigger paths cleanly. The build job is gated to release events so manual redeploys skip it entirely. The deploy job condition covers both the release and dispatch paths. TAG resolution and the yq strenv(TAG) pattern are correct and safe. No files require special attention. Important Files Changed
Reviews (3): Last reviewed commit: "fix: avoid expression injection in deplo..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves production deployment from direct Helm writes to the same declarative
appwrite-labs/assets-applicationsflow already used by staging.The
1.0.6release image built and pushed successfully, but direct Helm deployment conflicted with fields owned by Argo CD. This workflow now updatesproduction/mcp-for-docs/default.yaml, allowing Argo CD to reconcile the release without competing field managers.It also adds an explicit
taginput for workflow dispatch so a previously built release such as1.0.6can be redeployed safely.How was it tested?
actionlint .github/workflows/production.ymlgit diff --checkRelated issues
Follow-up to #18 and the failed production deployment job for release
1.0.6.