fix: require libcurl 8.22.0 for TLS shutdown cleanup - #102
Merged
Conversation
Greptile SummaryThis PR raises the minimum libcurl version in both compilation and runtime stages to include the TLS shutdown cleanup fix and adds a production-image structure test that verifies PHP loads libcurl 8.22.0 or newer.
Confidence Score: 5/5The PR appears safe to merge because the build enforces the required libcurl floor and the production structure test validates the loaded runtime version. No actionable failures remain: unavailable packages fail image construction rather than producing a vulnerable image, and the runtime assertion checks the library loaded in the freshly built production target. Important Files Changed
Reviews (1): Last reviewed commit: "fix: require libcurl 8.22.0 for TLS shut..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require libcurl 8.22.0 in the build and runtime images. Version 8.21.0 can retain TLS shutdown connections when driven through the socket-action API used by Swoole's curl hook, causing socket and memory growth. Alpine 3.24 now ships the upstream fix, so no source backport is needed.
The container structure test checks PHP's loaded libcurl version and rejects the existing Cloud image (8.21.0).
Validation:
This is a local transport regression test, not a production performance benchmark. No staging or production deployment is included in this PR.
Upstream: curl/curl#22282 and curl/curl@820c014.