fix: bump brace-expansion/js-yaml overrides to clear high-severity audit#3133
fix: bump brace-expansion/js-yaml overrides to clear high-severity audit#3133HarshMN2345 wants to merge 1 commit into
Conversation
bun audit --audit-level high was failing CI on transitive deps pulled in by eslint and @sentry/vite-plugin. Existing brace-expansion override didn't cover the patched range; added a js-yaml override.
Console (appwrite/console)Project ID: Sites (1)
Tip Git integration provides automatic deployments with optional PR comments |
Greptile SummaryThis PR updates Bun dependency metadata to clear high-audit findings. The main changes are:
Confidence Score: 4/5The dependency bump is close, but the lockfile integrity change should be fixed before merging.
bun.lock and package.json
|
| Filename | Overview |
|---|---|
| package.json | Updates dependency overrides for brace-expansion and js-yaml; the brace-expansion range remains broader than needed. |
| bun.lock | Locks the patched transitive versions, but also removes integrity hashes from three existing external URL dependencies. |
Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
bun.lock:129
**URL Tarballs Lose Integrity**
This lockfile refresh removes the `sha512` content pin from the external `pkg.vc` tarball for `@appwrite.io/console` while keeping the same URL. Frozen installs can no longer verify that this URL serves the same bytes that were previously locked and audited; the two Pink URL packages below lose the same protection.
### Issue 2 of 2
package.json:107
**Open-Ended Security Override**
The `brace-expansion` override is a lower-bound range, so a future lockfile refresh can satisfy it with a new major version even when the transitive consumer only requested the 5.x line. Since this override is meant to pin the patched dependency for CI, a tighter range such as the patched 5.x line would avoid pulling an unrelated major upgrade into an audit-only change.
Reviews (1): Last reviewed commit: "fix: bump brace-expansion/js-yaml overri..." | Re-trigger Greptile
| @@ -128,15 +129,15 @@ | |||
|
|
|||
There was a problem hiding this comment.
This lockfile refresh removes the sha512 content pin from the external pkg.vc tarball for @appwrite.io/console while keeping the same URL. Frozen installs can no longer verify that this URL serves the same bytes that were previously locked and audited; the two Pink URL packages below lose the same protection.
Prompt To Fix With AI
This is a comment left during a code review.
Path: bun.lock
Line: 129
Comment:
**URL Tarballs Lose Integrity**
This lockfile refresh removes the `sha512` content pin from the external `pkg.vc` tarball for `@appwrite.io/console` while keeping the same URL. Frozen installs can no longer verify that this URL serves the same bytes that were previously locked and audited; the two Pink URL packages below lose the same protection.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| "vite": "npm:rolldown-vite@latest", | ||
| "minimatch": "10.2.3", | ||
| "brace-expansion": ">=5.0.5", | ||
| "brace-expansion": ">=5.0.7", |
There was a problem hiding this comment.
The brace-expansion override is a lower-bound range, so a future lockfile refresh can satisfy it with a new major version even when the transitive consumer only requested the 5.x line. Since this override is meant to pin the patched dependency for CI, a tighter range such as the patched 5.x line would avoid pulling an unrelated major upgrade into an audit-only change.
Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 107
Comment:
**Open-Ended Security Override**
The `brace-expansion` override is a lower-bound range, so a future lockfile refresh can satisfy it with a new major version even when the transitive consumer only requested the 5.x line. Since this override is meant to pin the patched dependency for CI, a tighter range such as the patched 5.x line would avoid pulling an unrelated major upgrade into an audit-only change.
How can I resolve this? If you propose a fix, please make it concise.|
Superseded by #3134 — consolidating everything into a single PR. |

Summary
bun audit --audit-level highwas failing CI on two transitive high-severity advisories pulled in viaeslint/typescript-eslint/@sentry/vite-plugin:brace-expansion(ReDoS) andjs-yaml(quadratic CPU via merge-key chains).brace-expansionoverride (>=5.0.5) didn't reach the patched range; bumped to>=5.0.7and added ajs-yamloverride (^4.3.0).Test plan
bun audit --audit-level highreports 0 vulnerabilitiesbun run checkpasses with no new errors