Repository navigation
chore(deps): bump marked from 9.1.6 to 18.1.1 - #67
dependabot[bot] wants to merge 1 commit into
Conversation
🟡 Tier B · Needs changes before merging
This PR upgrades the site's Marked dependency from 9.1.6 to 18.1.1. It updates the npm lockfile and removes Nitro's nested lru-cache lock entry.
Fix with agent prompt### Issue 1
package-lock.json:1962
**Restore Nitro's optional lru-cache lock entry**
A clean `npm ci` fails with `Missing: lru-cache@11.5.3 from lock file`: Nitro still declares `lru-cache` as an optional peer, but this update removes `node_modules/nitro/node_modules/lru-cache` from the lockfile. This makes the CI install step fail before the build can run.
### Issue 2
package.json:19
**Update the image renderer for Marked's token API**
Marked 18 passes an image token object to custom renderer callbacks rather than the old positional `(href, title, text)` arguments. The unchanged handler in `src/app/projects.$projectId.tsx` therefore fails its URL check and returns `undefined`, so Markdown images in project descriptions no longer render correctly.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 2
⏳ Still open from earlier reviews · 1
Reviewed |
| "@vitejs/plugin-react": "^6.0.1", | ||
| "appwrite": "^16.1.0", | ||
| "marked": "^9.1.2", | ||
| "marked": "^18.1.1", |
There was a problem hiding this comment.
Update the image renderer for Marked's token API
Marked 18 passes an image token object to custom renderer callbacks rather than the old positional (href, title, text) arguments. The unchanged handler in src/app/projects.$projectId.tsx therefore fails its URL check and returns undefined, so Markdown images in project descriptions no longer render correctly.
Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 19
Comment:
**Update the image renderer for Marked's token API**
Marked 18 passes an image token object to custom renderer callbacks rather than the old positional `(href, title, text)` arguments. The unchanged handler in `src/app/projects.$projectId.tsx` therefore fails its URL check and returns `undefined`, so Markdown images in project descriptions no longer render correctly.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · bug · Reply if this doesn't apply.
Bumps [marked](https://github.com/markedjs/marked) from 9.1.6 to 18.1.1. - [Release notes](https://github.com/markedjs/marked/releases) - [Commits](markedjs/marked@v9.1.6...v18.1.1) --- updated-dependencies: - dependency-name: marked dependency-version: 18.1.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
b8b2e8c to
5ce9b1e
Compare
| "node": "20 || >=22" | ||
| } | ||
| }, | ||
| "node_modules/nitro/node_modules/unstorage": { |
There was a problem hiding this comment.
Restore Nitro's optional lru-cache lock entry
A clean npm ci fails with Missing: lru-cache@11.5.3 from lock file: Nitro still declares lru-cache as an optional peer, but this update removes node_modules/nitro/node_modules/lru-cache from the lockfile. This makes the CI install step fail before the build can run.
Prompt To Fix With AI
This is a comment left during a code review.
Path: package-lock.json
Line: 1962
Comment:
**Restore Nitro's optional lru-cache lock entry**
A clean `npm ci` fails with `Missing: lru-cache@11.5.3 from lock file`: Nitro still declares `lru-cache` as an optional peer, but this update removes `node_modules/nitro/node_modules/lru-cache` from the lockfile. This makes the CI install step fail before the build can run.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟠 Major · bug · Reply if this doesn't apply.
Bumps marked from 9.1.6 to 18.1.1.
Release notes
Sourced from marked's releases.
... (truncated)
Commits
cdbdc01chore(release): 18.1.1 [skip ci]2134976docs: add AGENTS.md (#4125)699a969chore(deps-dev): bump handlebars from 4.7.9 to 4.7.10 (#4133)6a57018fix: keep a backslash in a code span from hiding emphasis (#4117)eaa1ffffix: let indented and type 3-5 html blocks interrupt a paragraph (#4124)7e8754dperf: avoid repeated raw string copies in nested lists (#4082)cc07bb9fix: preserve enclosing link state after parsing images (#4123)627d9aefix: make walkTokens linear by appending values in place (#4121)4bd2528fix: respect tab stops in list continuation indentation (#4119)9e64a6afix: end blockquote before a lazy line after a heading, hr or html block (#4115)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for marked since your current version.