Repository navigation
chore(deps): bump react-dom and @types/react-dom - #65
dependabot[bot] wants to merge 1 commit into
Conversation
🟡 Tier B · Needs changes before merging
This PR upgrades
Fix with agent prompt### Issue 1
package.json:23
**Keep React on the same major as react-dom**
`react` remains on 18.3.1, but `react-dom` 19.3.1 requires the React 19 peer; the new `@types/react-dom` also requires `@types/react` 19. This leaves the renderer and React on incompatible versions, which can break rendering or hydration—please upgrade the React runtime and types together, or keep the DOM packages on 18.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 2
⏳ Still open from earlier reviews · 1
Reviewed |
| "node-appwrite": "^14.0.0", | ||
| "react": "^18.3.1", | ||
| "react-dom": "^18.3.1", | ||
| "react-dom": "^19.3.1", |
There was a problem hiding this comment.
Keep React on the same major as react-dom
react remains on 18.3.1, but react-dom 19.3.1 requires the React 19 peer; the new @types/react-dom also requires @types/react 19. This leaves the renderer and React on incompatible versions, which can break rendering or hydration—please upgrade the React runtime and types together, or keep the DOM packages on 18.
Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 23
Comment:
**Keep React on the same major as react-dom**
`react` remains on 18.3.1, but `react-dom` 19.3.1 requires the React 19 peer; the new `@types/react-dom` also requires `@types/react` 19. This leaves the renderer and React on incompatible versions, which can break rendering or hydration—please upgrade the React runtime and types together, or keep the DOM packages on 18.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟠 Major · bug · Reply if this doesn't apply.
Bumps [react-dom](https://github.com/react/react/tree/HEAD/packages/react-dom) and [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom). These dependencies needed to be updated together. Updates `react-dom` from 18.3.1 to 19.3.1 - [Release notes](https://github.com/react/react/releases) - [Changelog](https://github.com/react/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/react/react/commits/v19.3.1/packages/react-dom) Updates `@types/react-dom` from 18.3.7 to 19.3.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: "@types/react-dom" dependency-version: 19.3.0 dependency-type: direct:development update-type: version-update:semver-major - dependency-name: react-dom dependency-version: 19.3.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
f675e76 to
a2e18ff
Compare
Bumps react-dom and @types/react-dom. These dependencies needed to be updated together.
Updates
react-domfrom 18.3.1 to 19.3.1Release notes
Sourced from react-dom's releases.
... (truncated)
Changelog
Sourced from react-dom's changelog.
... (truncated)
Commits
61aa00d[19.3.x][Flight] Improve transport protocol (#37845)f4e439e[Fizz] Addnonceto renderedimport maps(#37339)21c89c9[DOM] Clean up Fragment listeners on signal abort (#37457)065bc84[DOM] Unobserve fragment IntersectionObserver targets after exit (#37408)ff7445e[DOM] Update HTML parser rules for new select parser (#34804)2dc7da7[test] Bump Jest to 30.4 (#37382)29d9d31[DOM] Copysourceonto the synthetic toggle event (#37389)269bd40[test] Remove the customtoThrowoverride for legacy V8 error messages (#37...a112448[DOM] Treat omitted Fragment Event listener options same ascapture: false...3d05080[Fizz] Construct the render lifetime controller only when it is needed (#37357)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for react-dom since your current version.
Updates
@types/react-domfrom 18.3.7 to 19.3.0Commits