Add commodore_api_url input to decommission step - #54
Open
thobens wants to merge 1 commit into
Open
Conversation
|
🚀 Merging this PR will release Merging will trigger workflows 🛠️ Auto tagging enabled with label |
1 similar comment
|
🚀 Merging this PR will release Merging will trigger workflows 🛠️ Auto tagging enabled with label |
HappyTetrahedron
approved these changes
Aug 26, 2026
| This step compiles the catalog to ensure you have a local checkout of the cluster repository | ||
| during decommissioning. | ||
| inputs: | ||
| - name: commodore_api_url |
Contributor
There was a problem hiding this comment.
Would you like to also copy the input's description from the setup step? (it includes the usual URLs which is convenient for copy paste)
Contributor
Author
There was a problem hiding this comment.
Do we repeat the description for every occurrence of an input? The description is in the first step the input is defined ("And a lieutenant cluster" from the shared steps)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The decommission step does not set
$COMMODORE_API_URL, which causes trouble when decommissioning a cluster on int.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog