Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
--retry <count>CLI flag that lets users override the per-notification retry count when sending via the command line.The REST API already supports a per-request
retryfield (PushNotification.Retry), which is honored by all three platforms (APNS, FCM, HMS) and capped by the configuredmax_retry. This change brings the same capability to CLI mode, which previously could only use the globalmax_retryconfig value.Changes
app/options.go— addRetryfield toOptions, bind--retryflag, pass throughCLISendOptions()app/sender.go— setreq.RetryinSendAndroidNotification,SendHuaweiNotification, andSendIOSNotificationwhen--retryis > 0main.go— document--retryin usage textapp/options_test.go,app/sender_test.go— tests for the new option and its default valueUsage
Notes
Testing
go test -v -tags sqlite ./app/...— all tests passgo build -tags sqlite .— builds successfullygolangci-lint run ./app/...— 0 issues