Fix symbolic nearest1d upsample output rank - #2840
Open
ZedingZhang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Conv1dRoot cause
The PyTorch frontend implements 1D nearest-neighbor interpolation by expanding the input with a dummy width dimension, invoking the 2D Torch upsample dialect op with
output_width=1, and squeezing that dimension afterward.The dialect op previously replaced both output dimensions with fresh symbols unconditionally. As a result, the dummy width was inferred as symbolic even though it was the constant
1. The following squeeze could not remove it during type inference, soConv1dreceived a rank-4 input and failed conversion.This change preserves the concrete value when an output dimension is known, while continuing to create a symbol for a dynamic dimension.
Tests
The new end-to-end regression test fails with the reported convolution shape error before the fix and passes afterward. It also asserts that the generated MIL convolution receives a rank-3 input.
Fixes #2837