[vminitd]: update filesystem operation to run in new namespace - #838
Open
saehejkang wants to merge 1 commit into
Open
[vminitd]: update filesystem operation to run in new namespace#838saehejkang wants to merge 1 commit into
saehejkang wants to merge 1 commit into
Conversation
Co-authored-by: John Logan <john_logan@apple.com>
7 tasks
jglogan
requested changes
Aug 9, 2026
| let containerMountFd = open("/proc/\(containerPid)/ns/mount", O_RDONLY | O_DIRECTORY | O_CLOEXEC) | ||
| if containerMountFd < 0 { | ||
| let error = swiftErrno("open") | ||
| throw RPCError(code: .internalError, message: "failed to open container mount namespace", cause: error) |
Contributor
There was a problem hiding this comment.
selfMountFd leaks here, doesn't it?
Contributor
Author
There was a problem hiding this comment.
Those leaks should be resolved in the defer block, no? I think we can remove the defer and then explicitly close both fds
Contributor
There was a problem hiding this comment.
Using defer is fine.
If 757 throws, the defer block at 760 is never reached and selfMountFd doesn't get closed. You need a defer for selfMountFd before 754, and the block at 760 need only contain containerMountFd.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
containerID, so that operations are always executed against the intended container’s mount namespace.