Show plugin settings in system property list#1696
Open
amarkdotdev wants to merge 1 commit into
Open
Conversation
1 task
amarkdotdev
force-pushed
the
codex/plugin-property-list
branch
from
11056e0 to
ac3b357
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
container system property listshowed core system configuration but omitted plugin-scoped values from[plugin.*]sections. This change includes those plugin settings in TOML and JSON output, using the same daemon-reported app-root and install-root config files as the core system properties. Nested plugin values preserve the existing first-match-wins layering behavior.Fixes #607
Testing
Commands run locally:
swift test --filter PluginPropertiesTestsswift test --filter ContainerCommandsTests