Fix vmnet VPN external interface refresh#1666
Open
0xMH wants to merge 2 commits into
Open
Conversation
0xMH
force-pushed
the
fix/1519-vpn-utun-nat
branch
from
089f4e1 to
91993c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Fixes #1519.
I dug into this issue a bit and found that containers could not reach addresses behind a VPN connection because the vmnet NAT network was created against the host network state at startup, but was not refreshed when VPN interfaces/routes changed. As a result, container traffic continued using stale vmnet NAT/routing state and failed to reach VPN-only destinations.
This change refreshes reserved vmnet NAT networks when host network state changes, configures vmnet with an active point-to-point tunnel interface when present, and updates the network allocator if vmnet selects a new subnet during refresh.
Testing