Repository navigation
Replace jsrsasign - #472
Draft
Preeternal wants to merge 5 commits into
Draft
Preeternal wants to merge 5 commits into
Preeternal wants to merge 5 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces jsrsasign with maintained ASN.1 libraries while preserving the public API and retaining JWS, X.509, and OCSP validation.
The full test suite passes locally, and the replacement improves compatibility with Cloudflare Workers using nodejs_compat. However, performance remains a concern.
In my Cloudflare Workers deployment, App Store Server Notifications V2 TEST requests frequently consumed tens of milliseconds of CPU time, with some measurements reaching 80 ms or more. The results varied considerably, and the measurements include application-level processing, so I cannot reliably attribute the observed CPU cost to the SDK replacement alone.
I am opening this as a draft to get feedback on the replacement approach and the performance tradeoffs before it is considered for merging.