Repository navigation
Reject fractional subscription period counts - #469
Open
Shubham-Padkonde wants to merge 2 commits into
Open
Shubham-Padkonde wants to merge 2 commits into
Shubham-Padkonde wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream now rejects fractional offer period counts in
HelperValidationUtils, butTransactionCommitmentInfoValidatorhas moved to its own range check and still accepts a fractionalbillingPeriodNumbersuch as1.5.Require
Number.isIntegerin that billing-period check while preserving upstream's support for boxed integer Numbers, the 1–12 range, and omitted optional fields. Retain the regression coverage for fractional helper inputs and offers, and cover primitive/boxed commitment values, range bounds, strings and null.Validation after merging main: the commitment regression fails before the additional integer check. TypeScript compilation and all 460 tests across 17 suites pass, including live verification tests.
git diff --checkpasses.