Repository navigation
Fix TypeError in verified-key cache eviction when cache exceeds MAXIMUM_CACHE_SIZE - #443
Closed
buildwithakhila wants to merge 1 commit into
Closed
buildwithakhila wants to merge 1 commit into
buildwithakhila wants to merge 1 commit into
Conversation
…not Object.keys array indices
Collaborator
|
Fixed in #473, thank you for your contribution though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SignedDataVerifier.verifyCertificateChain()'s cache-eviction loop iteratesfor (let key in Object.keys(this.verifiedPublicKeyCache)).Object.keys(...)returns an array, andfor...inover an array yields the array's indices ("0", "1", ...), not the cache's own keys. Sothis.verifiedPublicKeyCache[key]was alwaysundefinedinside the loop, and.cacheExpirythrew aTypeErrorthe moment the cache grew pastMAXIMUM_CACHE_SIZE(32 entries) — which happens for any long-running server (withenableOnlineChecks: true) that verifies enough distinct certificate chains within the 15-minute cache window.Fix: iterate the cache's keys directly with
for...of Object.keys(...)instead offor...in Object.keys(...).Added a regression test that seeds the cache past
MAXIMUM_CACHE_SIZEwith expired entries and verifies one more chain and it fails with the exact reportedTypeErroron the old code and passes with the fix.