ADFA-4910: pin Maps 'choose layers' CTA + free-space guard to the bottom - #322
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In fragment_k2go_maps_choose.xml the free-space guard (label + bar + "Fits") and the Download button lived inside the ScrollView, so with the layer groups expanded (Base map, Satellite, 3D terrain, Search) the CTA scrolled off-screen and was easy to miss.
Restructured to the same pinned-bottom pattern as the Get More hub (ADFA-4910) and the other wizard steps: the header + k2go_maps_groups scroll inside a weighted ScrollView, and the free-space guard + k2go_download_btn sit in a fixed bottom bar outside the scroll. Layout-only — all view IDs preserved, so MapsChooseFragment is untouched.
Verified: XML parses; only the layer groups scroll while the CTA and "Fits" stay visible.