ADFA-4986: keep the boot gate on re-entry during a live install - #321
Merged
Conversation
Tapping the install notification (or relaunching) mid-install re-entered LibraryActivity without EXTRA_INSTALLING, so onCreate took the normal-boot path: its autostart (~3.5s) and safety-dismiss (GATE_SAFETY_MS) timers fired, starting the server mid-provisioning and opening the gate over a system that was still downloading/extracting -> a broken library. - Derive `installing` also from the live install state: EXTRA_INSTALLING || InstallProgressRepository.get().current().isRunning() (DOWNLOADING/EXTRACTING/PROVISIONING), so a live install keeps the progress gate and skips the normal-boot timers. - Defense-in-depth: guard the autostart and safety-dismiss timers with !installing so a race (repo reports running just after onCreate) still can't start the server or lift the gate. Dismissal stays driven by the install SUCCESS terminal path; covers download and extraction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tapping the install notification (or relaunching) mid-install re-entered LibraryActivity without EXTRA_INSTALLING, so onCreate took the normal-boot path: its autostart (~3.5s) and safety-dismiss (GATE_SAFETY_MS) timers fired, starting the server mid-provisioning and opening the gate over a system that was still downloading/extracting -> a broken library.
installingalso from the live install state: EXTRA_INSTALLING || InstallProgressRepository.get().current().isRunning() (DOWNLOADING/EXTRACTING/PROVISIONING), so a live install keeps the progress gate and skips the normal-boot timers.Dismissal stays driven by the install SUCCESS terminal path; covers download and extraction.